-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] cooperator_website_recaptcha #110
base: 16.0
Are you sure you want to change the base?
[16.0][ADD] cooperator_website_recaptcha #110
Conversation
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
* move the recaptcha widget view to portal_recaptcha. * remove res.company.captcha_type (portal_recaptcha can now be enabled and disabled in the settings). * override WebsiteSubscription._additional_validate() instead of .validation().
fix author and website manifest properties to follow oca's guidelines.
use website_recaptcha_v2 instead of portal_recaptcha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
successful functional test
/ocabot merge nobump |
On my way to merge this fine PR! |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-110-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@dreispt thanks for taking time for this. this pr is ready, but it depends on OCA/website#1032, which should be merged first. could you help with that? |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
move
cooperator_website_recaptcha
module from coopiteasy/vertical-cooperative to the oca (and migrate it to 16.0).this is the 16.0 version of #44.
tests will fail until OCA/website#1032 is merged.